Attention is currently required from: Kevin Chang, Caveh Jalali.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47501 )
Change subject: mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1
......................................................................
Patch Set 13:
(2 comments)
File src/mainboard/google/volteer/variants/volteer2/gpio.c:
https://review.coreboot.org/c/coreboot/+/47501/comment/8eff424e_eee66f3c
PS13, Line 3: variant
nit - alphabetical order
File src/mainboard/google/volteer/variants/volteer2/variant.c:
https://review.coreboot.org/c/coreboot/+/47501/comment/86c202ad_c2378a56
PS13, Line 19: _up
_dn
If you can update this, I'll +2 and we can merge this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9939450213bac4c0d661759bef2f38f3fd3af76
Gerrit-Change-Number: 47501
Gerrit-PatchSet: 13
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Comment-Date: Wed, 05 May 2021 18:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment