Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47100 )
Change subject: sb/intel/bd82x6x: Use common AHCI library
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47100/5/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/sata.c:
https://review.coreboot.org/c/coreboot/+/47100/5/src/southbridge/intel/bd82x...
PS5, Line 132: const uintptr_t ahci_bar = pci_read_config32(dev, PCI_BASE_ADDRESS_5);
this should use probe_resource instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1679197c77c5b32c231fd51dd7465a3ebb1d7bd
Gerrit-Change-Number: 47100
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 09:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment