Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46599 )
Change subject: soc/intel/xeon_sp/skx/acpi.c: Update with cpx changes
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a...
File src/soc/intel/xeon_sp/skx/acpi.c:
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a...
PS1, Line 242: return NULL;
It was never called. void generate_t_state_entries(int core, int cores_per_package) was empty. […]
Oh, it is unused. I see.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71a59181226d79c40a4af405653c50c970fb720b
Gerrit-Change-Number: 46599
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 22 Oct 2020 16:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment