5 May
2022
5 May
'22
8:04 a.m.
Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64078 )
Change subject: soc/amd/common/block/psp/psp_gen2: simplify soc_read_c2p38 ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/psp/psp_gen2.c:
https://review.coreboot.org/c/coreboot/+/64078/comment/a7c5a1b4_e1d70a64 PS1, Line 116: SMN_PSP_PUBLIC_BASE
can this be defined in header file, as this base address will be needed for other smn offset access […]
that change is unrelated to this patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/64078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1abace04668947ba3223a107461a27dddc0a9d83
Gerrit-Change-Number: 64078
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: ritul guru ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: ritul guru ritul.bits@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 05 May 2022 14:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ritul guru ritul.bits@gmail.com
Gerrit-MessageType: comment