[coreboot-gerrit] [XS] Change in coreboot[main]: mainboard/qemu-aarch64: Get top of memory from device-tree blob

[Julius Werner (Code Review)]

Attention is currently required from: Alper Nebi Yasak, Nico Huber.

Julius Werner has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80364?usp=email )

Change subject: mainboard/qemu-aarch64: Get top of memory from device-tree blob
......................................................................

Patch Set 5: Code-Review+2

(1 comment)

File src/mainboard/emulation/qemu-aarch64/cbmem.c:

https://review.coreboot.org/c/coreboot/+/80364/comment/6326c0dc_107a40ef?usp... :
PS5, Line 12: 	top = fdt_get_memory_top((void *)_dram);
Does this mean that the FDT QEMU injects is always placed at the start of DRAM? If so, I'd recommend defining an explicit region for that in this board's `memlayout.ld` (and then referencing that region by name here, instead of `_dram`), so that future changes to this board won't accidentally place something else there and overwrite the FDT.