Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46834 )
Change subject: x86: Put bootblock startup code into .text._start section
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46834/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46834/1//COMMIT_MSG@16
PS1, Line 16: lot of space if it didn't.)
CB:47599 drops static C_ENV_BOOTBLOCK_SIZE. […]
I hope it's okay that I merge this for now so I can proceed here. Feel free to undo it again or rewrite it in a better way with CB:47599.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia84e6e33ec29584d356e226e8fdcb8c9334d49af
Gerrit-Change-Number: 46834
Gerrit-PatchSet: 9
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 00:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment