[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/herobrine: NVMe id determined by logical (not physical) bit

[Shelley Chen (Code Review)]

Attention is currently required from: Shelley Chen, Julius Werner.

Hello build bot (Jenkins), Doug Anderson, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/70230

to look at the new patch set (#3).

Change subject: mb/google/herobrine: NVMe id determined by logical (not physical) bit
......................................................................

mb/google/herobrine: NVMe id determined by logical (not physical) bit

NVMe is determined by a logical bit 1, not the physical SKU pin.
Thus, (logical) sku_id & 0x2 == 0x2 would mean that the device has
NVMe enabled on it.  Previously, I thought that it was tied to a
physical pin, but this is not correct.

BUG=b:254281839
BRANCH=None
TEST=flash and boot on villager and make sure that NVMe is not
     initialized in coreboot.

Change-Id: Iaa75d2418d6a2351d874842e8678bd6ad3c92526
Signed-off-by: Shelley Chen 
---
M src/mainboard/google/herobrine/mainboard.c
1 file changed, 26 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/70230/3