3 Feb
2022
3 Feb
'22
3:44 p.m.
Attention is currently required from: Kangheui Won, Reka Norman, Krishna P Bhat D. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61141 )
Change subject: mb/google/nissa: Add devicetree ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61141/comment/ac53b8c1_df2c7dfe PS5, Line 34: "
Should we also configure the AUX DC bias pads here: […]
You can always play it by ear and come back and refactor later once you have a better idea
--
To view, visit https://review.coreboot.org/c/coreboot/+/61141
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cd332fd05fde19078ebc4bd2797580abfb76f3b
Gerrit-Change-Number: 61141
Gerrit-PatchSet: 6
Gerrit-Owner: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-CC: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 15:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman rekanorman@chromium.org
Gerrit-MessageType: comment