Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41594 )
Change subject: AGESA f14: Factor out default MTRR settings
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41594/4/src/vendorcode/amd/agesa/f1...
File src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h:
https://review.coreboot.org/c/coreboot/+/41594/4/src/vendorcode/amd/agesa/f1...
PS4, Line 68: he fixed MTRR values to be set after memory initialization.
Add a comment that these are the default MTRR values?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id980e4671e51fe800188f0a84768a307c8965886
Gerrit-Change-Number: 41594
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 May 2020 07:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment