Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46861 )
Change subject: drivers/wifi/generic: Split wifi_generic_fill_ssdt into two functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... PS1, Line 181: dev->chip_info
could use config_of, but this is just reformatting so not a big deal.
Actually, we cannot use `config_of()` because it dies if there is no config. Since this driver is traditionally used both like a chip driver and a PCI driver, we will have to keep the dev->chip_info so that we can support the platforms using the PCI driver.