Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36670 )
Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................
mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen
Set GPP_C4 default to low to fix leakage voltage problem on touchscreen during power on.
BUG=b:142368161 BRANCH=Master TEST=emerge-hatch coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure touchscreen works.
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36670 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/helios/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Shelley Chen: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/helios/gpio.c b/src/mainboard/google/hatch/variants/helios/gpio.c index bebcf32..85eb3fc 100644 --- a/src/mainboard/google/hatch/variants/helios/gpio.c +++ b/src/mainboard/google/hatch/variants/helios/gpio.c @@ -33,6 +33,8 @@ PAD_NC(GPP_B19, NONE), /* C1 : SMBDATA ==> NC */ PAD_NC(GPP_C1, NONE), + /* C4 : TOUCHSCREEN_DIS_L */ + PAD_CFG_GPO(GPP_C4, 0, DEEP), /* C6 : GPP_C6 ==> NC */ PAD_NC(GPP_C6, NONE), /* C7 : GPP_C7 ==> NC */