HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42461 )
Change subject: nb/intel/ironlake/raminit.c: initialize 'reply.command'
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42461/5/src/northbridge/intel/ironl...
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42461/5/src/northbridge/intel/ironl...
PS5, Line 1751: struct uma_reply {
: u8 group_id;
: u8 command;
: u8 reserved;
: u8 result;
: u8 field2;
: u8 unk3[0x48 - 4 - 1];
: } __packed reply;
: struct reply message;
:
: message.command = 0;
yuck!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d13de549b6d428ac3675ee3f91eb5e42aeb25e8
Gerrit-Change-Number: 42461
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 Jul 2020 09:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment