build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )
Change subject: _WIP_ mb/amd/mandolin: Add Picasso CRB
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33772/3/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/33772/3/src/mainboard/amd/mandolin/...
PS3, Line 97: printk(BIOS_INFO, "write_pirq_routing_table done.\n");
Prefer using '"%s...", __func__' to using 'write_pirq_routing_table', this function's name, in a string
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b4a78e1eef9f998e1986da1506201eb505822eb
Gerrit-Change-Number: 33772
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Jul 2019 22:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment