5 Nov
2020
5 Nov
'20
9:36 a.m.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45578 )
Change subject: mb/hp: Add HP EliteBook Folio 9480m ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... PS8, Line 39: sata_port0_gen3_dtle
Oh, nice. According to Broadwell code, the port0 and port1 DTLE settings are backwards. […]
Oh. So we need to add P2,P3 support in LPT-LP as in CB:18408, and set the values in the boards.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45578
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2328c43cbb1f488aa1d0ddd9116814d971e5d8ae
Gerrit-Change-Number: 45578
Gerrit-PatchSet: 8
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bill XIE persmule@hardenedlinux.org
Gerrit-CC: Pablo Stebler pablo@stebler.xyz
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Nov 2020 09:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-MessageType: comment