[coreboot-gerrit] Change in coreboot[master]: mb/amd: Add Pollock CRB Cereme as Mandolin variant

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )

Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant
......................................................................

Patch Set 21: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
PS21, Line 13: # TODO: provide separate APCB for Cereme
I guess this would need to be handled at some point?

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/variants/cereme/early_gpio.c:

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
PS21, Line 4: ../../gpio.h
> that would result in duplicate gpio. […]

IMHO, I find the baseboard subdir in `variants/` quite confusing. I think it would make more sense to have the `baseboard` concept out of `variants` for the sake of clarity.