Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54855 )
Change subject: mainboard/google/brya: Add S3/S0ix wake events AC connect/disconnect ......................................................................
mainboard/google/brya: Add S3/S0ix wake events AC connect/disconnect
Enabling AC connect/disconnect wake events in brya to meet Chrome OS wake requirements. These changes are similar to Volteer and Shadowmountain.
BUG=none BRANCH=None TEST=manual tested DUT wakes for AC connect/disconnect in S0ix
Change-Id: I14b3efd429e3aa701af534f150baf35fcdeb9f35 Signed-off-by: madhusudanarao amara madhusudanarao.amara@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54855 Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Sooraj Govindan sooraj.govindan@intel.corp-partner.google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h 1 file changed, 7 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved Sooraj Govindan: Looks good to me, but someone else must approve Madhusudanarao Amara: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h index d01b450..34297bf 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h @@ -33,13 +33,16 @@ /* * EC can wake from S3/S0ix with: * 1. Lid open - * 2. Power button - * 3. Key press - * 4. Mode change + * 2. AC Connect/Disconnect + * 3. Power button + * 4. Key press + * 5. Mode change */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) #define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) /* Log EC wake events plus EC shutdown events */