7 Feb
2019
7 Feb
'19
11:41 p.m.
Enrico Granata has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31278 )
Change subject: mb/google/kahlee: Use GPIO_10 for EC_SYNC_IRQ ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31278/1/src/ec/google/chromeec/acpi/cros_ec.... File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/#/c/31278/1/src/ec/google/chromeec/acpi/cros_ec.... PS1, Line 38: GpioInt This might be a good time to ask the question: do we know of a (reasonable) way to make this work using the Interrupt ACPI resource instead of GpioInt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If499d24511bbaa7054207b7e0b98445723332c4f
Gerrit-Change-Number: 31278
Gerrit-PatchSet: 1
Gerrit-Owner: Edward Hill ecgh@chromium.org
Gerrit-Reviewer: Edward Hill ecgh@chromium.org
Gerrit-Reviewer: Enrico Granata egranata@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Duncan Laurie dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment