Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence. ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 37: !gpio_get_output(GPIO_LTE_RESET)
The intention is to reduce the effect of delaying to other variants and will check with HW Eng as we […]
Checked with kuten@ and the comment is keeping to enable LTE power should be fine for all variants. But personally would like to prevent delays here from non-LTE SKUs.
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 56: lte_power_off_gpios
Copy that and will try.
Done.
https://review.coreboot.org/c/coreboot/+/34188/5/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/5/src/mainboard/google/octopu... PS5, Line 229: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 0, DEEP, NONE, TxLASTRxE, DISPUPD), /* AVS_I2S1_MCLK -- LTE_OFF_ODL */
line over 96 characters
change to output low for non-LTE SKUs so will output high only in LTE SKU.