Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 4: ramstage-y += mainboard.c Please change the location to variant.c which aligns others variants although phaser did do it in mainboard.c . Thanks.
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 25: if (google_chromeec_cbi_get_sku_id(&sku_id)) Please call get_board_sku() intead. The reason is because there is a cache so no necessary to communicate to EC every time.