Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44915 )
Change subject: soc/intel/common: Add SSDT generation for Intel USB4 PCIe ports
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44915/14/src/soc/intel/common/block...
File src/soc/intel/common/block/usb4/pcie.c:
https://review.coreboot.org/c/coreboot/+/44915/14/src/soc/intel/common/block...
PS14, Line 80: .read_resources = pci_dev_read_resources,
: .set_resources = pci_dev_set_resources,
: .enable_resources = pci_dev_enable_resources,
This is actually not correct any more. Since the driver switched from handling a PCI device to a generic device, this is setting the operations incorrectly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44915
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7086b06346ce63fab6bef4077fb76ae1d30dc1eb
Gerrit-Change-Number: 44915
Gerrit-PatchSet: 14
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 00:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment