Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Don't use .bss from car.ld if not running XIP ......................................................................
Patch Set 1:
(1 comment)
NVM, should have visited the code more thorougly.
If I understand correctly, only CAR && !XIP environments are directly affected by this change, iow. Apollo Lake?
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h@266 PS1, Line 266: ENV_ROMSTAGE || ENV_SEPARATE_VERSTAGE
I'm starting to remember, APL's SRAM mimics ROM. So that could indeed […]
If we want to cover the bootblock, that could be more explicit:
(ENV_CACHE_AS_RAM && (ENV_BOOTBLOCK || !CONFIG(NO_XIP_EARLY_STAGES))
?