Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35466 )
Change subject: drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec ......................................................................
drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec
ACPI 6.3, ASL 20.2.2 (Name Objects Encoding) states:
LeadNameChar := 'A'-'Z' | '_' NameChar := DigitChar | LeadNameChar
Hence, the Intel WiFi names generated in ASL are required to be upper-cased letters.
BUG=b:141206986 TEST=Reflash and confirmed SSDT table has correct name.
Change-Id: I803b9bc81804eec7bd5220b9dbc6ddd0bb0ecbcc Signed-off-by: Andrew McRae amcrae@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35466 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/wifi/generic.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/src/drivers/wifi/generic.c b/src/drivers/wifi/generic.c index b593ffe..fc88f4a 100644 --- a/src/drivers/wifi/generic.c +++ b/src/drivers/wifi/generic.c @@ -239,7 +239,8 @@ { static char wifi_acpi_name[WIFI_ACPI_NAME_MAX_LEN];
- snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02x", + /* ACPI 6.3, ASL 20.2.2: (Name Objects Encoding). */ + snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02X", (dev_path_encode(dev) & 0xff)); return wifi_acpi_name; }