Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40721/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40721/1//COMMIT_MSG@13 PS1, Line 13: srubbing
nit: scrubbing
Done
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... PS1, Line 377: /* Test ECC in normal mode! */
what's that comment supposed to mean? Maybe "can't do this earlier because it needs to be done in no […]
Done
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... PS1, Line 386: i = 1;
This skips the entire first megabyte, right? Maybe change the comment to "Test up to TSEG. […]
Done