Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47774 )
Change subject: ec/kontron/kempld: Add ACPI to access to internal registers ......................................................................
Patch Set 3: Code-Review+1
Sorry, but I don't see the point of this. I peeked at the follow-up, but it is equally reasoning-free. If there's a real reason to add this, please explain it.
I was also confused by the commit message. Technically, what this does is advertising (and thereby reserving) the resource range _and_ (I guess that's the point) bind it to the `KEU0001` HID. This could then be picked up by an OS driver.
The HID is odd, though. As the Linux driver (`kempld-core`) uses `KEM0001`. So I wonder if this doesn't result in a warning when Linux loads the driver that can't find the ACPI part but uses the same resources? Or maybe not, because it sees that we don't use them in ASL? Dunno.
Anyway, I think this goes into the right direction. But we should check first if it really works.