Sorry, but I don't see the point of this. I peeked at the follow-up, but it is equally reasoning-free. If there's a real reason to add this, please explain it.

I was also confused by the commit message. Technically, what this
does is advertising (and thereby reserving) the resource range _and_
(I guess that's the point) bind it to the `KEU0001` HID. This could
then be picked up by an OS driver.

The HID is odd, though. As the Linux driver (`kempld-core`) uses
`KEM0001`. So I wonder if this doesn't result in a warning when
Linux loads the driver that can't find the ACPI part but uses the
same resources? Or maybe not, because it sees that we don't use
them in ASL? Dunno.

Anyway, I think this goes into the right direction. But we should
check first if it really works.

Patch set 3:Code-Review +1

View Change

To view, visit change 47774. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5088892936a48730d0d132b4ade1f3f600a9a40
Gerrit-Change-Number: 47774
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 02 Dec 2020 22:59:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment