[coreboot-gerrit] Change in coreboot[master]: mb/google/parrot: Put trailing statement in the next line

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49201 )

Change subject: mb/google/parrot: Put trailing statement in the next line
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
> But is hiding an empty statement hiding something? […]

Good point. To me, the while with in-line semicolon construct is very easy to mistake for a regular function call. I agree that the lone semicolon can be removed and wreak all kinds of havoc, though.

Another approach that would work is this:

while (1) {
         if (exit_condition_true())
                 break;
 }

We could also use a helper macro:

#define wait_until(cond) do { } while (!(cond))

Wait... This compiles!

do; while (!exit_condition_true());