Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81255?usp=email )
Change subject: amdfwtool: Set the table size only for FWs
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81255/comment/7661f9a1_85e295f3 :
PS5, Line 561: if (dir->header.additional_info_fields.dir_size == 0)
would be good if you can add a comment here that this results in dir_size only getting updated the f […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81255?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dfbbb55912c8e37243c351427a8df89c12e5da8
Gerrit-Change-Number: 81255
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 13:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment