build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30951 )
Change subject: AGESA fam12/fam14: Drop amdfamX_conf.c file include ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family12/n... File src/northbridge/amd/agesa/family12/northbridge.c:
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family12/n... PS1, Line 77: return 0; Statements should start on a tabstop
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family12/n... PS1, Line 91: tempreg = (nodeid&0xf) | ((nodeid & 0x30)<<(8-4)) | (linkn << 4) | ((io_max&0xf0)<<(12-4)); //limit line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family12/n... PS1, Line 94: tempreg = 3 /*| (3 << 4)*/ | ((io_min&0xf0)<<(12-4)); //base :ISA and VGA ? line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family12/n... PS1, Line 99: static void set_mmio_addr_reg(u32 nodeid, u32 linkn, u32 reg, u32 index, u32 mmio_min, u32 mmio_max, u32 nodes) line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... PS1, Line 75: return 0; Statements should start on a tabstop
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... PS1, Line 89: tempreg = (nodeid&0xf) | ((nodeid & 0x30)<<(8-4)) | (linkn << 4) | ((io_max&0xf0)<<(12-4)); //limit line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... PS1, Line 92: tempreg = 3 /*| (3 << 4)*/ | ((io_min&0xf0)<<(12-4)); //base :ISA and VGA ? line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... PS1, Line 96: static void set_mmio_addr_reg(u32 nodeid, u32 linkn, u32 reg, u32 index, u32 mmio_min, u32 mmio_max, u32 nodes) line over 80 characters
https://review.coreboot.org/#/c/30951/1/src/northbridge/amd/agesa/family14/n... PS1, Line 101: tempreg = (nodeid&0xf) | (linkn << 4) | (mmio_max&0xffffff00); //limit line over 80 characters