Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Żygowski, Paul Menzel.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82671?usp=email )
Change subject: ec/dasharo/ec: add support for Dasharo EC ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82671/comment/8501d7ae_5d43c6d8?usp... : PS1, Line 10: Dasharo-specific features
There are already other variants of EC firmware drivers forked from the same origin in the tree. […]
To expand a bit more on this, we've added, removed and changed a lot of functionalities in EC FW (i.e. removed System76 EC lockdown, removed keyboard backlight control in OS and implemented our own in EC, added and removed a number of EC commands, changed S0ix handling), so I thought trying to maintain all of those in the same codebase would be difficult and not make a lot of sense.
https://review.coreboot.org/c/coreboot/+/82671/comment/10f35a9b_ee5c3bc0?usp... : PS1, Line 10: Dasharo-specific features will be added in subsequent commits.
Please mention the coreboot commit the copy is based on.
Added to the commit message
https://review.coreboot.org/c/coreboot/+/82671/comment/b2e4a2d7_180385f9?usp... : PS1, Line 11:
Should we mention that: […]
Added both points to the commit message