Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34447 )
Change subject: soc/intel/common: Set controller state to active in uart init
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34447/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34447/6//COMMIT_MSG@11
PS6, Line 11: One more argument struct device *dev has been added to uart_lpss_init function for the same.
please split this in 2 lines.
https://review.coreboot.org/c/coreboot/+/34447/6//COMMIT_MSG@14
PS6, Line 14: Verify no timeouts seen during UART controller enumeration sequence in CML and ICL platforms.
ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0187267670e1dea3e1d5e83d0b29967724d6063e
Gerrit-Change-Number: 34447
Gerrit-PatchSet: 6
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jul 2019 06:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment