21 Nov
2019
21 Nov
'19
1:14 p.m.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37069 )
Change subject: trogdor: add support for Bubs variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 21: select EC_GOOGLE_CHROMEEC_SWITCHES if BOARD_GOOGLE_TROGDOR
I would assume that you get the linker issues Doug mentioned (for things like get_recovery_mode_swit […]
Yeah, this made me compile.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9bc98863c4f33c19e295b642f48c51921ed984
Gerrit-Change-Number: 37069
Gerrit-PatchSet: 1
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Douglas Anderson dianders@chromium.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment