[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add support for UARTs on PCH-H

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )

Change subject: soc/intel/cannonlake: Add support for UARTs on PCH-H
......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40405/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40405/9//COMMIT_MSG@9 
PS9, Line 9: On PCH-H all UARTs can't be used under Windows.
You probably mean "not every UART can be used"?

https://review.coreboot.org/c/coreboot/+/40405/9//COMMIT_MSG@12 
PS9, Line 12: ACPI code for the Intel LPSS ACPI driver.
This is a separate topic and should be in its own change. For the above,
you remove false advertisement. For this you add support code.

I also see no reason to call it a work around? Isn't it just standard
ACPI code that Windows wants to see?

https://review.coreboot.org/c/coreboot/+/40405/9/src/soc/intel/cannonlake/pc... 
File src/soc/intel/cannonlake/pch_h.c:

PS9: 
I generally prefer per-platform drivers if there is anything platform
specific. But I don't see it in this case. Can you elaborate, why this
can't be common code?