Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45746/6/src/soc/intel/jasperlake/sp... File src/soc/intel/jasperlake/spd/empty.spd.hex:
PS6: Rather than using the empty.spd.hex, can we please add placeholder.spd.hex - Reason I say this is because SoC might support different memory technologies. And the SPD for each of these might differ in size. Since empty.spd.hex gets used even when there are gaps in DRAM strap ID allocation, I think it would be safer to have empty-ddr4, empty-lpddr4 files rather than a single empty.spd.hex which can result in silent failures later. And for the case of initial variant creation, we can use placeholder.spd.hex which we know should not be used any time later.
Next steps: 1. Add placeholder.spd.hex/placeholder_spd to tigerlake and jasperlake (Ideally we can get rid of the duplicate files under each SoC once we move SPDs out of the SoC directory) - This can in fact be just 1 byte in size. 2. Use placeholder SPDs for initial variant creation.
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... PS6, Line 5: .spd.hex I think you don't need the .spd.hex suffix here?