Martin Roth (gaumless@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10680
-gerrit
commit de7e582c408f345a382544438afe223a322883ba Author: Martin Roth gaumless@gmail.com Date: Sun Jun 28 09:44:31 2015 -0600
southbridge/amd/pi/hudson: Fix HUDSON_DISABLE_IMC kconfig warning
Platforms selecting the HUDSON_DISABLE_IMC symbol were showing the warning:
warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && CPU_AMD_AGESA_BINARY_PI) selects HUDSON_DISABLE_IMC which has unmet direct dependencies (SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN)
By moving the definition of the symbol outside of the if block and removing the default n, we can get rid of the warning without changing the value for any platform.
Change-Id: I5c1bdfbcf3c5c44ee05b8c5e679f6854d784d8dc Signed-off-by: Martin Roth gaumless@gmail.com --- src/southbridge/amd/pi/hudson/Kconfig | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig index 36716fa..237183a 100644 --- a/src/southbridge/amd/pi/hudson/Kconfig +++ b/src/southbridge/amd/pi/hudson/Kconfig @@ -35,6 +35,9 @@ config SOUTHBRIDGE_AMD_PI_KERN select HAVE_USBDEBUG_OPTIONS select HAVE_HARD_RESET
+config HUDSON_DISABLE_IMC + bool + if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN
config BOOTBLOCK_SOUTHBRIDGE_INIT @@ -65,10 +68,6 @@ config HUDSON_XHCI_FWM help Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0
-config HUDSON_DISABLE_IMC - bool - default n - config HUDSON_IMC_FWM bool "Add IMC firmware" depends on !HUDSON_DISABLE_IMC