10 Mar
2020
10 Mar
'20
1:20 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28565 )
Change subject: util/board_status: Add support of CMOS values dump ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/28565/2/util/board_status/board_sta... File util/board_status/board_status.sh:
https://review.coreboot.org/c/coreboot/+/28565/2/util/board_status/board_sta... PS2, Line 387: if [ -n "$NVRAMTOOL_PATH" ]; then
instead of this extensive test, why not just initialize nvramtool_cmd to "nvramtool" and override th […]
This is potentially for a follow-up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39
Gerrit-Change-Number: 28565
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 10 Mar 2020 20:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment