mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37795 )
Change subject: sc7180: add qclib_post_fixup to allow SoC specific code ......................................................................
Patch Set 9:
Patch Set 8:
Agreed that the underlying problem needs to be addressed and it is. I added this callback as a safety-net for future issues that come up, perhaps on one board and not another. There is a similar callback ahead of running qclib so various boards can load non-standard blobs, e.g. While I can't identify a use-case now, this is future-proofing. Happy to leave or remove. Will re-visit when current bug in qclib is addressed and current need is removed.
Let's not add interfaces before we need them. It doesn't cost anything to add them later.
I have squashed this change in with the HACK patch that used it. No way around introducing this interface to address this temporary problem, otherwise mistral board, that uses same common/qclib.c file is impacted. When trogdor qclib no longer requires workaround, this interface dies with the hack patch.