Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38849 )
Change subject: soc/intel/common: Update Jasperlake Device IDs ......................................................................
Patch Set 6:
(5 comments)
Please mark the comments as resolved once done. That way All-Comments-Resolved gets checked.
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... PS5, Line 2820: 0X4d87
adding to above, Plan is to add on need basis, instead of listing all IDs, which may go unused.
Done
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... PS5, Line 3094: PCI_DEVICE_ID_INTEL_JSP_SATA
Done. Added the other SATA ID too. […]
Done
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... PS5, Line 3231: 0x4dc7
0x4dc7 is the correct one. We have raised a request to the EDS team. […]
Done
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... PS5, Line 3392: #define PCI_DEVICE_ID_INTEL_JSL_GT0 0x4E41
Done. Removed it. Thank you.
Done
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids.... PS5, Line 3453: #define PCI_DEVICE_ID_INTEL_JSL_EHL 0x4532 : #define PCI_DEVICE_ID_INTEL_EHL_ID_1 0x4510
These are not applicable to JSP and are EHL specific. Only 0x4e22 holds good for JSP.
Done