Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: SPM: mt8183: support spm suspend in coreboot
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm...
File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm...
PS1, Line 77: unsigned int con1, retry = 0, timeout = 5000;
You might want to add the unit to the variable name: timeout_us. coreboot’s stopwatch framework should help you with this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 2
Gerrit-Owner: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 25 Jul 2019 11:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment