Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36430 )
Change subject: arch/acpi.h: Avoid explicitly assign values to enum names
......................................................................
Patch Set 2:
Hm, I'm not too sure about this: these values are exported to outside consumers and so I think there's value making them explicit. Otherwise some future developer might decide to reorder the entries alphabetically, or add an entry somewhere in between.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5aa9762051780b67013f67f101112fc7a0bf6e
Gerrit-Change-Number: 36430
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 11:49:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment