[coreboot-gerrit] Change in coreboot[master]: amd/picasso: Load x86 microcode from CBFS modules

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )

Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG@11 
PS5, Line 11:
> In theory, it can. But it needs too much work to extract generality and individuality. […]

Yes, please add a note to the commit message though, what it’s too much work.

https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/update_... 
File src/soc/amd/picasso/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/update_... 
PS1, Line 23: /* Array terminator */
            : 		{ 0xffffff, 0x0000 },
> Solved?

If the code is more readable that way, then yes. If you do not need a terminator, if all you need is the size, then please go with the size.