Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37116 )
Change subject: sb/ibexpeak: Use macros instead of hard-coded IDs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37116/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37116/1//COMMIT_MSG@9
PS1, Line 9: This patch replaces hard-coded PCI IDs with macros
: from pci_ids.h and adds the related IDs to it.
:
: The resulting binary doesn't differ from the one
: without this patch.
Reflow for 75 characters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3326f142d483f5008fb2ac878f30c1a3a72f500f
Gerrit-Change-Number: 37116
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Mar 2020 13:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment