Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34423 )
Change subject: soc/amd/picasso: Begin adding FSP support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/reset.c File src/soc/amd/picasso/reset.c:
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/reset.c... PS2, Line 70: die("unknown reset type");
Does this die make sense? Maybe assert so we die if fatal asserts are turned on, and just do the co […]
Sure. Also, it looks like there's no point handling a case for any _<num> unless we add that to the FSP. Cold and warm is already called from within the driver.
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/romstag... File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/romstag... PS2, Line 148: todo: verify TOM < UMA region when UMA is below 4GB
If this isn't handled by the end of the patch stack, could you file a bug to make sure it get handle […]
Will file a bug due to uncertainty of when we'll be able to test it by moving UMA.