[coreboot-gerrit] Change in ...coreboot[master]: util/intelvbttool: Free file object on error path

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32685 )

Change subject: util/intelvbttool: Free file object on error path
......................................................................

util/intelvbttool: Free file object on error path

Prevents a memory leak.

Found-by: Coverity Scan #1396047
Signed-off-by: Jacob Garber 
Change-Id: I4c72a17351d8afbe23302edfeeba74b17608aef2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32685
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M util/intelvbttool/intelvbttool.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/util/intelvbttool/intelvbttool.c b/util/intelvbttool/intelvbttool.c
index f8e4bda..715b39a 100644
--- a/util/intelvbttool/intelvbttool.c
+++ b/util/intelvbttool/intelvbttool.c
@@ -1028,8 +1028,10 @@
    if (old_vbt) {
    	if (oh->vbt_offset + vbt_size(old_vbt) == fo->size) {
    		/* Located at the end of file - reduce file size */
-			if (fo->size < vbt_size(old_vbt))
+			if (fo->size < vbt_size(old_vbt)) {
+				free_fo(old_vbt);
    			return 1;
+			}
    		fo = remalloc_fo(fo, fo->size - vbt_size(old_vbt));
    		if (!fo) {
    			printerr("Failed to allocate memory\n");