[coreboot-gerrit] Change in coreboot[master]: src/mainboard: Add PCI device for IUO1 and IOU2 to devicetree

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34540 )

Change subject: src/mainboard: Add PCI device for IUO1 and IOU2 to devicetree
......................................................................

Patch Set 1: -Code-Review

Would CB:34547 work for you?

I think it's a bad approach to require updates on other static devicetree files when you add code using config_of(). It appears for soc/ we could inherit .chip_info from 0:0.0 to auto-discoverable PCI devices that were not present in static tree. For split directory cpu/nb/sb platforms it would be a bit more tricky, but possible.