Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h:
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in...
PS2, Line 21: #include <stdint.h>
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. […]
yep, implicit includes tend to cause issues
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0eea9bfd0c8d9e3eba257b561980accf5b4bab4
Gerrit-Change-Number: 35267
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Sep 2019 17:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Name of user not set #1002476
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment