Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )
Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................
Patch Set 4:
Alternatively, move the `helpers.h` include into `types.h`? That should
properly reflect the intentions:
- `stddef.h` only provides standard functions,
- `types.h` gathers several includes for convenience.
Yeah, I'd be fine with that. I just want to avoid every single file having to include a dozen individual headers for all this general toolkit stuff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Gerrit-Change-Number: 37415
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Dec 2019 19:33:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment