[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Reinstate APL_SKIP_SET_POWER_LIMITS

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41786 )

Change subject: soc/intel/apollolake: Reinstate APL_SKIP_SET_POWER_LIMITS
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41786/1/src/soc/intel/apollolake/ch... 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/c/coreboot/+/41786/1/src/soc/intel/apollolake/ch... 
PS1, Line 325: if (CONFIG(APL_SKIP_SET_POWER_LIMITS)) {
             : 		printk(BIOS_INFO, "Skip the RAPL settings.\n");
             : 		return;
             : 	}
This is better but having it here would meen that in the case where APL_SKIP_SET_POWER_LIMITS is set the last function set_sci_irq() will not be reached. Would you mind to change it like this:

if (CONFIG(APL_SKIP_SET_POWER_LIMITS)) {
    printk(BIOS_INFO, "Skip the RAPL settings.\n");
} else {
    config = config_of_soc();
    /* Set RAPL MSR for Package power limits */
    soc_config = &config->power_limits_config;
    set_power_limits(MOBILE_SKU_PL1_TIME_SEC, soc_config);
}