build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43777 )
Change subject: mb/google/zork: Remove reset_gpio from bt when not supported ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 357: bt_cfg->reset_gpio.pin_count=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 359: #endif /* !DEVTREE_EARLY */ adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 375: xhci0_bt_dev = find_dev_nested_path(pci_root_bus(), xhci0_bt_path, ARRAY_SIZE(xhci0_bt_path)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 380: xhci1_bt_dev = find_dev_nested_path(pci_root_bus(), xhci1_bt_path, ARRAY_SIZE(xhci1_bt_path)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 394: #endif /* !DEVTREE_EARLY */ adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/variant.c:
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 14: if (board_version <= 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 22: } adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/variant.c:
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 7: static void update_bluetooth_configuration() { Bad function definition - void update_bluetooth_configuration() should probably be void update_bluetooth_configuration(void)
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 7: static void update_bluetooth_configuration() { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 13: if (board_version <= 2) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/variant.c:
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 7: static void update_bluetooth_configuration(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43777/1/src/mainboard/google/zork/v... PS1, Line 11: if (board_version <= 1) { braces {} are not necessary for single statement blocks