Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29530 )
Change subject: siemens/mc_apl3: Set Full Reset Bit into Reset Control Register ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c:
https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 67: into in
https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 68: * When Bit 3 is set to 1 the PCH will driving SLP_S3 active (low). Maybe add: ...SLP_S3 active (low) when the reset button is pressed. SLP_S3 is then used on the mainboard to generate the right reset timing.
https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 68: driving drive