EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config ......................................................................
Patch Set 14:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 39: #define GPIO_MEM_CH_SEL GPP_A17 I can help confirm this with HW. But I think we don't need this.
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 27: void variant_memory_init(FSP_M_CONFIG *mem_cfg); weak this.
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltan/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 12: romstage-y += gpio.c this is not belong this patch.
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 16: verstage-y += gpio.c same above.
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltaur/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 49: int __weak variant_memory_sku(void) not weak here.
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 61: void __weak variant_memory_init(FSP_M_CONFIG *mem_cfg) same above.